develooper Front page | perl.perl5.porters | Postings from November 2014

TONYC TPF Grant 4 report #6

From:
Tony Cook
Date:
November 17, 2014 12:37
Subject:
TONYC TPF Grant 4 report #6
Message ID:
20141117123749.GB3785@mars.tony.develop-help.com
[Hours]         [Activity]
2014/11/03      Monday
 0.43           #123105 merge the mess, try to make a patch work, comment
                - op-type patchset
 0.33           #123089 comment and close - svpeek.t on android
 0.87           #123096 review patch and referenced thread, apply to blead
                - IO::Socket::connected documentation
 2.42           #45331 research, some code
=====
 4.05

2014/11/04      Tuesday
 2.47           #45331 more research, testing - win32 stat on \\?\UNC
 0.80           #122002 re-test and push to blead - -Dmksymlinks
 0.73           #45331 make it work in a basic way, need non-DST to test
 0.30           #123123 review, comment about missing patch - nmake and
                DynaLoader
 1.37           #121337 produce a fix, testing, comment - utf8cache.t
                broken
=====
 5.67

2014/11/05      Wednesday
 0.58           #123124 review, test and apply to blead - constants in
                make_ext.pl
 0.28           #120487 re-test and apply to blead
 0.23           #122823 re-test and apply to blead - make clean
 0.18           #123130 review, test and apply to blead
 0.27           #123131 review and consider a related bug
=====
 1.54

2014/11/06      Thursday
 0.20           #123135 reproduce and start bisect - $^N utf8 bug
 1.30           #123119 review and comment
 0.80           #123135 produce a patch and comment
=====
 2.30

2014/11/07      Friday
 0.85           #123136 review
 1.32           #108276 review, re-test and apply to blead, re-work
                whitespace patch
 0.27           #123119 comment
 1.47           #108276 testing, apply to blead
=====
 3.91

Which I calculate is 17.47 hours

Approximately 16 tickets were reviewed or worked on, and 6 patches
were applied.

[perl #121337] is interesting in the number of things that were wrong
with the first test in t/op/utf8cache.t.

This was reported by Daniel Dragan where op/utfcache.t was
producing a an error message, but was still passing:

  1..15
  '-' is not recognized as an internal or external command, operable program or batch file.
  ok 1
  ok 2 - quadratic pos 
  ...

This turned out to be a problem from when the test was originally
written in 2009 - it uses C< open CHILD, '-|' > which doesn't work on
Win32.

It was further muddled when the code was converted to use test.pl
instead of manual TAP output in 2011.  Previously the code would
attempt to load Devel::Peek, but the modified code only checked
$Config{extensions}, so the module wasn't available to produce the
test output.

Finally, the test included no description, and the test performed was
obscure enough that it was difficult to tell what it was testing for.
The original commit message is fairly obscure.

(and post-finally, I missed committing a change to use and allow a
skip count for skip_without_dynamic_extension(), covered later by
Jarkko.)



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About