develooper Front page | perl.perl5.porters | Postings from November 2014

[perl #123224] Bleadperl v5.21.5-413-gd0a32af breaks GPHAT/MooseX-Method-0.44.tar.gz

Thread Previous
From:
Father Chrysostomos
Date:
November 17, 2014 00:52
Subject:
[perl #123224] Bleadperl v5.21.5-413-gd0a32af breaks GPHAT/MooseX-Method-0.44.tar.gz
Message ID:
rt-4.0.18-22766-1416185500-652.123224-75-0@perl.org
# New Ticket Created by  Father Chrysostomos 
# Please include the string:  [perl #123224]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org/Ticket/Display.html?id=123224 >


I’m surprised this breaks anything:

commit d0a32af375ac806258a97cce0091ce4b3636f8dc
Author: Father Chrysostomos <sprout@cpan.org>
Date:   Sun Nov 2 16:50:40 2014 -0800

    Remove SvREADONLY_on from op.c:op_const_sv
    
    If we turn on the padtmp flag, then this this SV will never be seen in
    lvalue context, so whether it is read-only is irrelevant.  Don’t even
    bother making it so.

diff --git a/op.c b/op.c
index 4c5cbd5..3b98a32 100644
--- a/op.c
+++ b/op.c
@@ -7792,7 +7792,6 @@ Perl_op_const_sv(pTHX_ const OP *o, CV *cv, CV *outcv)
                    }
                }
                sv = newSVsv(sv);
-               SvREADONLY_on(sv);
                SvPADTMP_on(sv);
                return sv;
            }

So something fishy is going on that I need to look into.  It may be that I have just missed something and this commit needs to be reverted.

This is related to #123213, but only in that it was part of the same commit sequence.

-- 

Father Chrysostomos


Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About