develooper Front page | perl.perl5.porters | Postings from November 2014

[perl #123089] ext/XS-APItest/t/svpeek.t fails on Android

From:
Tony Cook via RT
Date:
November 2, 2014 23:49
Subject:
[perl #123089] ext/XS-APItest/t/svpeek.t fails on Android
Message ID:
rt-4.0.18-18676-1414972141-1216.123089-15-0@perl.org
On Thu Oct 30 08:47:32 2014, Hugmeir wrote:
> I was trying to build perl on Android and spotted this failure:
> 
> ok 12 - $-
> ok 13 - $!
> ok 14 - $?
> ok 15 - $|
> not ok 16 -  $1
> #   Failed test ' $1'
> #   at t/svpeek.t line 31.
> #          got: 'PVMG("t"\0)'
> #     expected: 'PVMG()'
> # Looks like you failed 1 test of 52.
> FAILED at test 16
> Failed 1 test out of 1, 0.00% okay.
> ../ext/XS-APItest/t/svpeek.t
> 
> The test itself is this:
> 
>   "abc" =~ m/(b)/; # Don't know why these magic vars have this content
>   is (DPeek ($1),    'PVMG()', ' $1');
> 
> where DPeek is a wrapper around sv_peek() from dump.c. I may be
> missing something, but it looks like the test itself has two wrongs:
> First, it needs to use $1 for the value of the previous match to get
> populated; second, if it wanted 'PVMG()', then the regex prior should
> either not capture anything, or fail.
> 
> The attached patch solves the issue for me, but I'm rather curious as
> to why this only affected Android.

Looks like you applied this as f97a82b4769f9dc8deb2cc1bb6e3dfa3c52e3caa, so closing this ticket.

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=123089



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About