develooper Front page | perl.perl5.porters | Postings from November 2014

[perl #123106] [PATCH 0/4] RFC op-type patchset

Thread Next
From:
Jim Cromie
Date:
November 2, 2014 21:02
Subject:
[perl #123106] [PATCH 0/4] RFC op-type patchset
Message ID:
rt-4.0.18-18670-1414962121-1591.123106-75-0@perl.org
# New Ticket Created by  Jim Cromie 
# Please include the string:  [perl #123106]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org/Ticket/Display.html?id=123106 >


This patchset cleans up op_type and op_ppaddr initialization, using
CHANGE_TYPE macro, added 4 years ago.  In doing so it "promotes" its
use as the "normal" way to do so, one of its goals is that setting
o->op_ppaddr should indicate something special.

Patch 1 uses CHANGE_TYPE in 49 callsites.
Patch 2 removes pp_mapstart trickery, with 1 line in op.c
Patch 3 reduces variation in OP_AELEMFAST setup
Patch 4 folds pp_opaddr setup into S_alloc_LOGOP

TODO: CHANGE_TYPE would properly apply in a few more spots;
perl.c could use it once, if it were hoisted out of op.c (into op.h)
op.c could use it, but for a macro/sequence-point issue with ++(o->op_type).


Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About