Front page | perl.perl5.porters |
Postings from October 2014
On 29 October 2014 06:55, Andreas J. Koenig via RT <
perlbug-followup@perl.org> wrote:
> # New Ticket Created by (Andreas J. Koenig)
> # Please include the string: [perl #123079]
> # in the subject line of all future correspondence about this issue.
> # <URL: https://rt.perl.org/Ticket/Display.html?id=123079 >
>
>
> (Resend. Apologies if you see this twice. In my first posting I probably
> was too terse to be accepted by perlbug. Retrying with more words. I
> have been waiting for one hour and perlbug did not accept my previous
> attempt, so I need to make another try.)
>
> As per subject. Triaging requires version number differentiation.
> Cpantesters have to rely on the data collected at the source, so there
> is no way to look into files or try things out to see whether a
> particular feature is there or is working. We have just the summary of
> version informations in the test reports. So we urgently need a
> different version number on every change.
>
>
Still a bit terse Andreas. :-)
This is about FC changing the bundled Test::More without a version bump.
To save others digging it references this commit. Shouldn't this have been
picked up by the porting tests?
Yves
commit df8d57333de0f29a6161f8306687739b123fc1f1
Author: Father Chrysostomos <sprout@cpan.org>
Date: Mon Oct 27 12:49:15 2014 -0700
Restore previous Test::More::skip functionality
Even though it would warn about no skip count, it would default to 1.
The latest alpha breaks that, causing test failures on Windows.
diff --git a/cpan/Test-Simple/lib/Test/More.pm
b/cpan/Test-Simple/lib/Test/More.pm
index 7f8afaf..1b12ac0 100644
--- a/cpan/Test-Simple/lib/Test/More.pm
+++ b/cpan/Test-Simple/lib/Test/More.pm
@@ -259,8 +259,10 @@ sub _skip {
# If there is no plan we do not need to worry about counts
my $need_count = $plan ? !($plan->directive && $plan->directive eq 'NO
PLAN') : 0;
- $ctx->alert("$func() needs to know \$how_many tests are in the block")
- if $need_count && !defined $how_many;
+ if ($need_count && !defined $how_many) {
+ $ctx->alert("$func() needs to know \$how_many tests are in the
block");
+ $how_many = 1;
+ }
$ctx->alert("$func() was passed a non-numeric number of tests. Did
you get the arguments backwards?")
if defined $how_many and $how_many =~ /\D/;
diff --git a/cpan/Test-Simple/t/Legacy/skip.t
b/cpan/Test-Simple/t/Legacy/skip.t
index c67e680..6a0612a 100644
--- a/cpan/Test-Simple/t/Legacy/skip.t
+++ b/cpan/Test-Simple/t/Legacy/skip.t
@@ -7,7 +7,7 @@ BEGIN {
}
}
-use Test::More tests => 15;
+use Test::More tests => 16;
BEGIN {
require warnings;
Thread Previous
|
Thread Next