Front page | perl.perl5.porters |
Postings from October 2014
On Sun Aug 31 17:42:34 2014, preaction@me.com wrote: > On Aug 31, 2014, at 8:57 AM, James E Keenan via RT <perlbug- > followup@perl.org> wrote: > > > On Sun Aug 31 01:24:33 2014, madcityzen@gmail.com wrote: > >> The git format-patch -M option takes a branch (blead), not a remote > >> name (origin). > > > > As for the first patch: I myself had never heard of the '-M' option > > to git-format-patch, so I have never used it -- and the documentation > > in 'man git-format-patch' for '-M' doesn't draw a clear connection to > > me to the "branch vs. remote" issue. So I would like others' > > opinions. > > Had I read the git-format-patch docs (like I did just now), I'd've saw > that it's not the -M option taking the argument, but just the > <revision range> argument to git-format-patch: We want all commits > from where we branched from "blead" (the "start" of the branch, after > being properly rebased if necessary) to the current HEAD (which is > implicit by not saying anything after the ".."). Yes, your original explanation for the change was wrong, but your change is correct nonetheless. :-) I have applied the two remaining patches as c98156331 and 5df2441. Thank you. -- Father Chrysostomos --- via perlbug: queue: perl5 status: open https://rt.perl.org/Ticket/Display.html?id=122663