develooper Front page | perl.perl5.porters | Postings from October 2014

Re: Data::Alias and op_private flag assertions

Thread Previous
Dave Mitchell
October 13, 2014 10:02
Re: Data::Alias and op_private flag assertions
Message ID:
On Thu, Oct 09, 2014 at 03:27:59PM -0000, Father Chrysostomos wrote:
> Data::Alias adds its own private flags to certain ops.

Hmm - unwarranted chumminess to the max!

Just as an aside: now that PL_op_private_valid[] exists, it might be worth
in future for Data::Alias to assert that a private bit isn't assigned
before grabbing it?

> So it trips on
> the assertion failure recently added to make sure that no ops have
> invalid private flags set.
> I'm wondering about the best approach to solve this.  (I'm trying to
> patch Data::Alias for other issues, but this one is now preventing all
> tests from passing for me.)  Adding an op-freeing hook or registering
> a custom op seems like overkill (and I'm not sure of all the implica-
> tions of the latter).
> So would it be acceptable to skip the private flag check if the ppaddr
> has been reassigned?  That would make this kind of hackery slightly
> easier.  And the assertion failure is happening for cosmetic rea-
> sons anyway.

That sounds like a reasonable compromise.

The Enterprise is captured by a vastly superior alien intelligence which
does not put them on trial.
    -- Things That Never Happen in "Star Trek" #10

Thread Previous Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About