Daniel Dragan wrote: > Perl_tmps_grow is marked as public API in embed.fnc, but has no cpan > grep usage, and it is highly unlikely it is used in darkpan, it is used > once or twice on CPAN grep through macros, I want to change the meaning > of a param in Perl_tmps_grow. I've correct all the macros that use it to > the new meaning. Should I rename Perl_tmps_grow to visbly break darkpan > code that was using it directly? "_flags" is not appropriate since I > didn't add a param to the function call, only changed the meaning of the > existing one. If it should be renamed what should its new name be? > Perl_tmps_grow_x? Perl_tmps_new_grow? Perl_tmps_grow2? There have been several cases in the past where A was used in embed.fnc where X would have been more appropriate, more due to mis- takes or ignarance than by intent. I think this is one of those cases, and that we could just change the parameters without a new function name, as long as we also change A to X in embed.fnc. If you don't feel as confident about it as I do, then, as long as the new function uses X, not A, the name doesn't actually matter so much. We could always change it later.Thread Previous