develooper Front page | perl.perl5.porters | Postings from October 2014

[perl #122405] [PATCH] Started work on "Remove the use of SVs as temporaries in dump.c"

Thread Next
From:
Tony Cook via RT
Date:
October 8, 2014 00:40
Subject:
[perl #122405] [PATCH] Started work on "Remove the use of SVs as temporaries in dump.c"
Message ID:
rt-4.0.18-18638-1412728808-539.122405-15-0@perl.org
On Wed Aug 13 01:41:56 2014, creaktive@gmail.com wrote:
> I have to admit I've made a hell of a mess within this ticket.
> Should I squash my commits & apply for a new ticket to supersede this one?

Could you supply a new squashed patch for this ticket?

Some of the issues I see so far:

- many of the changes appear to be pure whitespace changes, which should be a separate patch

- your naming patch left _sv_catpv(), which still uses a leading _ and doesn't operate on SVs

At a higher level I'm a bit worried that you're going to run out of space displaying a complex SV.

From reading Nicholas' note in Porting/todo.pod it reads like he's expecting a more complex buffer implementation, eg:

  struct bf {
    char *buf;
    size_t used;
    size_t alloced;
  };

with a small set of functions to allocate and update that - like a mini SV.

I'm not sure how well that would integrate into PerlIO though.

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=122405

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About