Re: [perl #122629] [PATCH] sv_grow: performance improvement forshort strings

On Tue, Oct 07, 2014 at 04:32:28PM -0700, Tony Cook via RT wrote:
> On Mon Oct 06 22:48:11 2014, tonyc wrote:
> > On Mon Sep 01 12:43:17 2014, rurban wrote:
> > > This is caused by a wrong memcmp in attributes.xs:100
> > > patch attached
> > 
> > That patch also includes a change unrelated to attributes.xs.
> > 
> > I plan to apply the attached subset of that patch.
> 
> I've applied that subset to blead as ff5314c5aa54b172122507017cac034acf1c4bf7.

Sorry I didn't catch this sooner.  This should be reverted (though it's
really no big deal) since I already fixed that problem more succinctly
in commit dd369969a.  That was in [perl #122701], which is marked
as resolved (thanks to FC for wrangling the bug tracker!).  The
memEQs macro is designed for just this sort of thing, when called correctly,
and the extra len check is redundant.

-- 
    Andy Dougherty		doughera@lafayette.edu

• [perl #122629] [PATCH] sv_grow: performance improvement for short strings by Tony Cook via RT
• Re: [perl #122629] [PATCH] sv_grow: performance improvement forshort strings by Andy Dougherty
• [perl #122629] [PATCH] sv_grow: performance improvement for short strings by Tony Cook via RT
• Re: [perl #122629] [PATCH] sv_grow: performance improvement forshort strings by Dave Mitchell