On Fri Sep 12 07:40:07 2014, demerphq wrote: > On 12 September 2014 07:09, Father Chrysostomos via RT < > perlbug-followup@perl.org> wrote: > > > On Thu Sep 11 16:45:15 2014, jkeenan wrote: > > > On Wed Sep 10 20:10:29 2014, andreas.koenig.7os6VVqR@franz.ak.mind.de > > > wrote: > > > > git bisect > > > > ---------- > > > > commit cfc7ef1544efe7a47158840b7ae10976abeff21b > > > > Author: Father Chrysostomos <sprout@cpan.org> > > > > Date: Mon Sep 8 22:37:46 2014 -0700 > > > > > > > > Stop barewords from trumping subs with (*) proto > > > > > > > > sample fail report > > > > ------------------ > > > > http://www.cpantesters.org/cpan/report/cf0d975e-3850-11e4-9db3- > > > > e2a5cc4edbc1 > > > > > > > > > > Breakage confirmed at commit 0eb7ca0. > > > > > > $ ~/testing/blead/bin/prove -I./lib -vb t/*.t > > > t/example1.t .. > > > 1..2 > > > Not a GLOB reference at /home/jkeenan/.cpan/build/Hook-LexWrap-0.24- > > > 41H4Bj/blib/lib/Hook/LexWrap.pm line 34. > > > # Looks like your test exited with 255 before it could output > > > anything. > > > Dubious, test returned 255 (wstat 65280, 0xff00) > > > Failed 2/2 subtests > > > [snip] > > > t/test.t ...... Can't wrap non-existent subroutine main::1 at t/test.t > > > line 15. > > > > The tests are depending on the ability of the * prototype to override a > > sub call and change a bareword into a string. > > > > If we fix the tests, then these two modules that use it will fail: > > > > Acme::ComeFrom > > RT::Crypt::SMIME > > > > I’m not worried about Acme::ComeFrom. So it looks as though our net > > breakage is 2 modules. Hook::LexWrap’s tests need to be fixed and its > > documentation changed to encourage fat arrows or explicit initial splats. > > RT::Crypt::SMIME just needs a pair of quotation marks. > > > > Considering the small degree of breakage, is it worth going back to the > > insanity we had before? > > > > IMO, no, your patch should stay and the modules be fixed. > > Yves Filed bug ticket for Hook-LexWrap: https://rt.cpan.org/Ticket/Display.html?id=99021 -- James E Keenan (jkeenan@cpan.org) --- via perlbug: queue: perl5 status: open https://rt.perl.org/Ticket/Display.html?id=122757Thread Previous