develooper Front page | perl.perl5.porters | Postings from September 2014

Re: #endif comment in embed.fnc doesn't match opening macro test

Thread Previous
From:
Dave Mitchell
Date:
September 1, 2014 13:27
Subject:
Re: #endif comment in embed.fnc doesn't match opening macro test
Message ID:
20140901132655.GK5204@iabyn.com
On Sun, Aug 31, 2014 at 01:59:29AM -0400, bulk88 wrote:
> I was looking at
> http://perl5.git.perl.org/perl.git/blob/HEAD:/embed.fnc#l2490
> 
> 
> 2487 ApR     |PerlIO *|PerlIO_stdin
> 2488 ApR     |PerlIO *|PerlIO_stdout
> 2489 ApR     |PerlIO *|PerlIO_stderr
> 2490 #endif /* PERLIO_LAYERS */<<<<<<<<<<<<<<<<<<<<<<
> 2491
> 2492 : Only used in dump.c
> 2493 p       |void   |deb_stack_all
> 
> but the #if for that closing #endif is
> 
> 2461 #if defined(USE_PERLIO)
> 
> Should this be fixed to match the actual macro being tested? Git blaming it
> shows the comment didn't match the #if from day 1 of NIS's code.


Well spotted. Fixed with 57630fb

-- 
The Enterprise is captured by a vastly superior alien intelligence which
does not put them on trial.
    -- Things That Never Happen in "Star Trek" #10

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About