develooper Front page | perl.perl5.porters | Postings from August 2014

[perl #122663] PATCH: Fix git-format-patch commands and clarify git-send-email policy

Thread Next
From:
James E Keenan via RT
Date:
August 31, 2014 13:57
Subject:
[perl #122663] PATCH: Fix git-format-patch commands and clarify git-send-email policy
Message ID:
rt-4.0.18-26569-1409493470-743.122663-15-0@perl.org
On Sun Aug 31 01:24:33 2014, madcityzen@gmail.com wrote:
> The git format-patch -M option takes a branch (blead), not a remote
> name (origin).
> 
> I removed the paragraph that suggested that one could use git send-
> email to send in a patch, and replaced it with a link to the "Sending
> patch emails" section.
> 
> Finally, I noticed a missing close paren.
> 

Doug,

Thanks for your careful reading of this documentation.  I've applied the third of your patches in commit f6cce60a032fd351c1c7a6961fd3bcb043b3a784.

I held off on applying the first two because I would like other people to take a look at those sections of pod/perlgit.pod.

As for the first patch: I myself had never heard of the '-M' option to git-format-patch, so I have never used it -- and the documentation in 'man git-format-patch' for '-M' doesn't draw a clear connection to me to the "branch vs. remote" issue.  So I would like others' opinions.

As for the second patch:  It seems to me that the section starting at "You should now send an email to ..." (line 265 in blead) and the section starting "=head2 Sending patch emails" (line 325 in blead) have substantial overlap and could benefit from even more copy-editing that you have provided.  Again, more eyeballs wanted.

> Should I be providing these things as separate patches like this? Or
> should they be a single patch?

In this case, it was good that your provided individual patches!

Thank you very much.
Jim Keenan


---
via perlbug:  queue: perl5 status: new
https://rt.perl.org/Ticket/Display.html?id=122663

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About