develooper Front page | perl.perl5.porters | Postings from August 2014

[perl #121159] List form of pipe open not implemented on Win32

Thread Next
From:
bulk88 via RT
Date:
August 28, 2014 22:09
Subject:
[perl #121159] List form of pipe open not implemented on Win32
Message ID:
rt-4.0.18-27567-1409263774-1721.121159-15-0@perl.org
On Mon Aug 18 23:05:20 2014, tonyc wrote:
> 
> Patch attached for picking apart.
> 
> Tony

win32_popen returns a PerlIO*, which is wrong since win32_* are C lib level replacements, not general perl api. If something. It should be called Perl_do_popen, and remove win32_popen.

+		    Move(args_pvs, args_pvs+w32_perlshell_items, narg+1, const char *);
+		    for (i = 0; i < w32_perlshell_items; ++i)
+		        args_pvs[i] = w32_perlshell_vec[i];

Why is 1 a Move and the other is a for loop? How about alloca instead of the Newx?

-- 
bulk88 ~ bulk88 at hotmail.com

---
via perlbug:  queue: perl5 status: new
https://rt.perl.org/Ticket/Display.html?id=121159

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About