develooper Front page | perl.perl5.porters | Postings from July 2014

[perl #122281] [PATCH] clean up sv_isobject usage

From:
Tony Cook via RT
Date:
July 21, 2014 00:51
Subject:
[perl #122281] [PATCH] clean up sv_isobject usage
Message ID:
rt-4.0.18-18528-1405903862-753.122281-15-0@perl.org
On Sun Jul 13 05:28:10 2014, bulk88 wrote:
> On Sun Jul 13 05:22:17 2014, bulk88 wrote:
> > This is a bug report for perl from bulk88@hotmail.com,
> > generated with the help of perlbug 1.40 running under perl 5.21.2.
> >
> >
> > -----------------------------------------------------------------
> > [Please describe your issue here]
> >
> > See attached patch.
> >
> 
> Original patch had bad indenting (spaces instead of tabs), fixed patch
> attached.

Spaces are preferred.

One pattern I see a lot in this patch is replacing C<< sv_isobject(foo) >> with C<< SvROK(e) && SvOBJECT(SvRV(e)) >> to skip the magic in sv_isobject().

Wouldn't it be better to define a sv_isobject_nomg() macro?

Tony




---
via perlbug:  queue: perl5 status: new
https://rt.perl.org/Ticket/Display.html?id=122281



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About