develooper Front page | perl.perl5.porters | Postings from July 2014

[perl #122282] [PATCH] remove alot of duplicate

Thread Previous
James E Keenan via RT
July 20, 2014 03:14
[perl #122282] [PATCH] remove alot of duplicate
Message ID:
On Sun Jul 13 07:06:46 2014, bulk88 wrote:
> This is a bug report for perl from,
> generated with the help of perlbug 1.40 running under perl 5.21.2.

Reviewing the patch, I felt that it would be clearer if we moved the assignments to $open_as and $fileno out from inside parentheses, in order to improve clarity.

I then realized that some of the variable declarations were superfluous and that others could/should be moved closer to where thy are actually used.

And since we're now doing a lot of work on spawn_with_handles(), I figured we should get rid of the hard tabs as indents.

All of which led to a new patch, attached.  Does it look okay?

Thank you very much.
Jim Keenan

via perlbug:  queue: perl5 status: new

Thread Previous Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About