develooper Front page | perl.perl5.porters | Postings from July 2014

[perl #122282] [PATCH] Open3.pm:spawn_with_handles remove alot of duplicate

Thread Previous
From:
James E Keenan via RT
Date:
July 20, 2014 03:14
Subject:
[perl #122282] [PATCH] Open3.pm:spawn_with_handles remove alot of duplicate
Message ID:
rt-4.0.18-26293-1405826081-496.122282-15-0@perl.org
On Sun Jul 13 07:06:46 2014, bulk88 wrote:
> This is a bug report for perl from bulk88@hotmail.com,
> generated with the help of perlbug 1.40 running under perl 5.21.2.
> 

Reviewing the patch, I felt that it would be clearer if we moved the assignments to $open_as and $fileno out from inside parentheses, in order to improve clarity.

I then realized that some of the variable declarations were superfluous and that others could/should be moved closer to where thy are actually used.

And since we're now doing a lot of work on spawn_with_handles(), I figured we should get rid of the hard tabs as indents.

All of which led to a new patch, attached.  Does it look okay?

Thank you very much.
Jim Keenan

---
via perlbug:  queue: perl5 status: new
https://rt.perl.org/Ticket/Display.html?id=122282

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About