On 6 May 2014 16:57, Ricardo Signes <perl.p5p@rjbs.manxome.org> wrote: > * demerphq <demerphq@gmail.com> [2014-04-25T03:18:05] > > Hiya. This is the branch with my current musings and patches waiting > > to be merged. > > Heyo. > > I've had a look at them, and they look primarily to me like patches to > apply in > 5.21.0. Picking c5a5de3a2139d788715d6d1623129c5dd4dc6891 seems plausible, > though. > > Anybody else? > > These are the ones I would like to see cherry-picked: commit 2619a8d523f24ad3e52be6894a99a56e8f9bf484 Author: Yves Orton <demerphq@gmail.com> Date: Sun Apr 13 13:31:55 2014 +0200 Hash::Util - bump version to 0.17 commit cf7ed3eeeaf55833b895f694920774f6ad05c97c Author: Yves Orton <demerphq@gmail.com> Date: Sun Apr 13 13:30:09 2014 +0200 Hash::Util - we should do the mean/stddev on the on the occupied buckets not all buckets. This was always intended to the be average chain-length, which implies that empty buckets with no-chains at all are excluded. commit 9e120828524726f2eab01ecb5217c239daf66591 Author: Yves Orton <demerphq@gmail.com> Date: Sun Apr 13 13:29:44 2014 +0200 Hash::Util - fix typos in hash_stats() documentation commit ba9468d3a9aeddd565358cfc0a3d10dc0d41a76d Author: Yves Orton <demerphq@gmail.com> Date: Sun Apr 13 12:54:12 2014 +0200 hv_func.h - fix seed initialization in sdbm and djb2 hashing algorithms. In a previous commit I added code to "mix in" the length of the string into the seed used by these functions, to avoid issues with zero seeds, and with the hope that it makes it harder to create multicollision attacks against these hash functions. Unfortunately when I restructured the seed logic for the inline functions in hv_func.h I messed it up, and these hash functions were broken. I never noticed because they are both such bad hash functions for our needs that I never built with them, and we have no infrastructure to make it easy to test building with non-standard hash functions so it never got automatically tested. Hopefully at some point someone will find a round-tuit and teach Configure about selecting alternate hash functions. commit c5a5de3a2139d788715d6d1623129c5dd4dc6891 Author: Yves Orton <demerphq@gmail.com> Date: Fri Mar 21 17:47:45 2014 +0100 universal.c - utf8::downgrade($x,FAIL_OK) is not supposed to treat FAIL_OK as an integer -- perl -Mre=debug -e "/just|another|perl|hacker/"Thread Previous | Thread Next