[perl #121712] [PATCH] Coverity: regcomp.c etc.

On Wed Apr 23 16:59:42 2014, jhi wrote:
> On Wednesday-201404-23, 15:06, Hugo van der Sanden via RT wrote:
> > There seems also to be a copy/paste in the comments:
> > +#  define REG_EXTFLAGS_NAME_SIZE $REG_EXTFLAGS_NAME_SIZE /*
> > sizeof(PL_reg_intflags_name) */
> > +#  define REG_EXTFLAGS_NAME_SIZE 32 /* sizeof(PL_reg_intflags_name)
> > */
> >
> > I assume both should s/int/ext/.
> >
> > Hugo
> 
> The updated patch attached.
> 
> It also includes the suggestion to use assert(), though I went ahead
> and
> used the new shiny ASSUME() -- please correct as appropriate, I might
> have misunderstood ASSUME.
> 
> (Further change from the earlier incarnation is that the new symbols
> are made visible under DEBUGGING, not PERL_EXT_RE_BUILD.)

+#ifdef DEBUGGING
+#  define REG_INTFLAGS_NAME_SIZE 14 /* sizeof(PL_reg_intflags_name) */
+#endif

It's not really sizeof(), but the element count.

Outside of that I think it's good.

Tony


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=121712

• Re: [perl #121712] [PATCH] Coverity: regcomp.c etc. by Jarkko Hietaniemi
• Re: [perl #121712] [PATCH] Coverity: regcomp.c etc. by Jarkko Hietaniemi
• [perl #121712] [PATCH] Coverity: regcomp.c etc. by Tony Cook via RT
• [perl #121712] [PATCH] Coverity: regcomp.c etc. by Tony Cook via RT