[perl #121739] [PATCH] Coverity: don't try using O_BINARY and O_TEXT in non-Windows platforms

On Sat Apr 26 12:01:06 2014, jhi wrote:
> In non-Windows platforms the O_BINARY and O_TEXT are defined, but with 
> both probably as zeros, which is not very useful if they are being 
> tested with bit-and.  Leads into unreachable code.
> 
> Attached.

I suspect this patch is incorrect, at least for Cygwin.

O_TEXT and O_BINARY on Cygwin do have a meaning, but PERLIO_USING_CRLF is explicitly undefined.

I think a better check would be that O_BINARY or O_TEXT is non-zero.

I can't think of a perl level check to demonstrate the incorrectness.

Tony

---
via perlbug:  queue: perl5 status: new
https://rt.perl.org/Ticket/Display.html?id=121739

• Re: [perl #121739] [PATCH] Coverity: don't try using O_BINARY andO_TEXT in non-Windows platforms by Jarkko Hietaniemi
• Re: [perl #121739] [PATCH] Coverity: don't try using O_BINARY andO_TEXT in non-Windows platforms by Jarkko Hietaniemi
• [perl #121739] [PATCH] Coverity: don't try using O_BINARY and O_TEXT in non-Windows platforms by Tony Cook via RT
• Re: [perl #121739] [PATCH] Coverity: don't try using O_BINARY andO_TEXT in non-Windows platforms by Jarkko Hietaniemi
• Re: [perl #121739] [PATCH] Coverity: don't try using O_BINARY andO_TEXT in non-Windows platforms by Tony Cook
• [perl #121739] [PATCH] Coverity: don't try using O_BINARY and O_TEXT in non-Windows platforms by Tony Cook via RT