[perl #121738] [PATCH] Coverity: regcomp.c: bit-or used when bit-and meant

On Sat Apr 26 09:41:48 2014, jhi wrote:
> regcomp.c:14693-ish:
> 
> operator_confusion: ret->flags | 0x10 is always 1/true regardless of
> the values of its operand. This occurs as the logical first operand of 
> '&&'. Did you intend to use '&' rather than '|'?
> 
> -        && ! ((ANYOF_FLAGS(ret) | ANYOF_WARN_SUPER) && ALWAYS_WARN_SUPER))
> +        && ! ((ANYOF_FLAGS(ret) & ANYOF_WARN_SUPER) && ALWAYS_WARN_SUPER))
> 
> (confirmed by Karl Williamson)
> 
> Attached.

This appears (to me) to be a lost optimization opportunity rather than a critical bug.

Added as a 5.21.1 blocker so it will be applied after 5.20 is released.

Tony



---
via perlbug:  queue: perl5 status: new
https://rt.perl.org/Ticket/Display.html?id=121738

• [perl #121738] [PATCH] Coverity: regcomp.c: bit-or used when bit-and meant by Tony Cook via RT
• Re: [perl #121738] [PATCH] Coverity: regcomp.c: bit-or used whenbit-and meant by Karl Williamson