[perl #121336] valgrind errors in Perl_hv_iternext_flags

On Fri Feb 28 06:43:30 2014, davem wrote:
> On Wed, Feb 26, 2014 at 08:42:35PM -0800, Karl Williamson wrote:
> > dist/Thread-Queue/t/02_refs ...................................
> > ==23653== Thread 2:
> > ==23653== Conditional jump or move depends on uninitialised value(s)
> > ==23653==    at 0x59E78C: Perl_hv_iternext_flags (hv.c:2503)
> 
> These are all fixed by the following commit, which is a candidate for
> 5.18
> too.
> 
> commit 186460900eddc03b1e140296f25d2a6bf5fb9ec9
> Author:     David Mitchell <davem@iabyn.com>
> AuthorDate: Fri Feb 28 14:37:13 2014 +0000
> Commit:     David Mitchell <davem@iabyn.com>
> CommitDate: Fri Feb 28 14:37:13 2014 +0000
> 
> copy xhv_rand and xhv_last_rand in threads clone
> 
> valgrind complains about these fields being uninitialised when cloned
> into a
> new thread, because they aren't copied. It's fairly harmless, since
> these
> fields are just used to perturb hash key iteration; but for
> completeness,
> clone these fields too.

+1 from me for backport to maint-5.18.

Tony


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=121336

• Re: [perl #121336] valgrind errors in Perl_hv_iternext_flags by Karl Williamson
• [perl #121336] valgrind errors in Perl_hv_iternext_flags by Tony Cook via RT
• [perl #121336] valgrind errors in Perl_hv_iternext_flags by Tony Cook via RT