[perl #121474] [PATCH] pp_require collapse string mutators

On Sat Mar 22 11:14:01 2014, bulk88 wrote:
> On Thu Mar 20 17:07:10 2014, bulk88 wrote:
> > On Wed Mar 19 20:22:07 2014, bulk88 wrote:
> > > This is a bug report for perl from bulk88@hotmail.com,
> > > generated with the help of perlbug 1.39 running under perl 5.19.7.
> > >
> > >
> > > -----------------------------------------------------------------
> > > [Please describe your issue here]
> > >
> > > See attached patch.
> >
> > This failed some tests, the patch will need revision.
> 
> Attached. One issue I had was is the right number of getmagic calls
> happening.  The new code does call get magic on @INC slices. See
> callstack. The problem with the original patch was a missing % in the
> fmt string.

I'm inclined to reject this patch - it makes the code less clear (a review will wonder why it's using Perl_sv_catpvf_nocontext() instead of the current sv_catpvs()/sv_catsv()) for a minor reduction in size.

(Adding a comment wouldn't be a fix, just a band-aid.)

Tony


---
via perlbug:  queue: perl5 status: new
https://rt.perl.org/Ticket/Display.html?id=121474

• [perl #121474] [PATCH] pp_require collapse string mutators by bulk88 via RT
• Re: [perl #121474] [PATCH] pp_require collapse string mutators by Dave Mitchell
• [perl #121474] [PATCH] pp_require collapse string mutators by Tony Cook via RT