On 03/24/2014 02:22 PM, Tony Cook wrote: > On Mon, Mar 24, 2014 at 11:08:16AM -0400, Ricardo Signes wrote: >> >Finallly, some valgrind errors: >> > >> >15.https://rt.perl.org/Ticket/Display.html?id=121335 > This one appears to be NOTABUG (or NOTOURBUG) and I think it can be > removed as a blocker. > > There's still some discussion in how to prevent the false negative > being a problem in the future. I proposed just adding some comments to the code so that someone investigating the problem again would know that it is known. Now that we have a valgrind ticket number, that would go in the comment(s). > >> >16.https://rt.perl.org/Ticket/Display.html?id=121366 > I posted a brief analysis and a proposed fix yesterday, I wouldn't > mind some feedback. > Your patch looks good to me.Thread Previous | Thread Next