develooper Front page | perl.perl5.porters | Postings from March 2014

Re: regex or Test::More fail?

Thread Previous | Thread Next
From:
H.Merijn Brand
Date:
March 24, 2014 15:56
Subject:
Re: regex or Test::More fail?
Message ID:
20140324165622.0992a1ae@pc09.procura.nl
On Mon, 24 Mar 2014 09:57:14 +0100, "H.Merijn Brand"
<h.m.brand@xs4all.nl> wrote:

> % perl -MTest::More -wE'like("[   0\n    ]",qr{\A\[   0\n    ]\Z}ms);done_testing'
> ok 1
> 1..1
> % perl5.19.11 -MTest::More -wE'like("[   0\n    ]",qr{\A\[   0\n    ]\Z}ms);done_testing'
> not ok 1
> #   Failed test at -e line 1.
> #                   '[   0
> #     ]'
> #     doesn't match '(?^ums:\A\[   0\n    ]\Z)'
> 1..1
> # Looks like you failed 1 test of 1.

commit 7742aa6637b99424497eb15161fdb0a225288578
Author: David Mitchell <davem@iabyn.com>
Date:   Mon Mar 24 15:36:32 2014 +0000

    [perl #121484] /m causing false negative
    
    My recent commit d0d4464849e2b30aee8 in re_intuit_start() reduced the
    scope of a 'skip if multiline' check, so that certain optimisations
    weren't being unnecessarily skipped. Unfortunately it didn't reduce the
    scope enough, so a vital slen-- was being skipped in the
    SvTAIL-but-don't-fail case.
    
    This commit just moves the !multiline test further down, and updates the
    commentary and condition formatting a bit.
-----------------------------------------------------------------------

Fixed this problem. Thank you!
No time to check the others of the ticket Zefram pointed me at

-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.19   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/        http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About