develooper Front page | perl.perl5.porters | Postings from March 2014

Re: [perl #121484] /m causing false negative

Thread Previous
From:
Dave Mitchell
Date:
March 24, 2014 15:44
Subject:
Re: [perl #121484] /m causing false negative
Message ID:
20140324154339.GM1615@iabyn.com
On Fri, Mar 21, 2014 at 02:16:21PM +0000, Tom Hukins wrote:
> On Fri, Mar 21, 2014 at 06:01:01AM -0700, Zefram wrote:
> > $ perl5.19.10 -lwe 'print "wibble" =~ /\Awibble\z/m ? "yes" : "no"'
> > no
> > $ perl5.19.9 -lwe 'print "wibble" =~ /\Awibble\z/m ? "yes" : "no"'
> > yes
>  
> I've just bisected this to the following plausible-looking commit:

Thanks. Now fixed with

commit 7742aa6637b99424497eb15161fdb0a225288578
Author:     David Mitchell <davem@iabyn.com>
AuthorDate: Mon Mar 24 15:36:32 2014 +0000
Commit:     David Mitchell <davem@iabyn.com>
CommitDate: Mon Mar 24 15:36:32 2014 +0000

    [perl #121484] /m causing false negative
    
    My recent commit d0d4464849e2b30aee8 in re_intuit_start() reduced the
    scope of a 'skip if multiline' check, so that certain optimisations
    weren't being unnecessarily skipped. Unfortunately it didn't reduce the
    scope enough, so a vital slen-- was being skipped in the
    SvTAIL-but-don't-fail case.
    
    This commit just moves the !multiline test further down, and updates the
    commentary and condition formatting a bit.


-- 
The optimist believes that he lives in the best of all possible worlds.
As does the pessimist.

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About