develooper Front page | perl.perl5.porters | Postings from March 2014

[perl #121230] process group kill on Win32 broken in 5.17.2, regression 5.18

Thread Previous
From:
bulk88 via RT
Date:
March 21, 2014 20:58
Subject:
[perl #121230] process group kill on Win32 broken in 5.17.2, regression 5.18
Message ID:
rt-4.0.18-1041-1395435489-85.121230-15-0@perl.org
On Mon Mar 17 09:40:43 2014, davem wrote:
> On Fri, Feb 28, 2014 at 08:59:15PM -0800, bulk88 via RT wrote:
> > I don't think I will get a response. So it stays at 5 seconds and a new
> > patch mentioning 5.18.0 instead of 5.17.2 is attached.
> 
> Thanks, applied as af728ca1bc. I also took the libery of cleaning the code
> up a bit with the following commit:
> 
> commit 4c0e595c606032a1e1c0a922399a1e7bd2358ca9
> Author:     David Mitchell <davem@iabyn.com>
> AuthorDate: Mon Mar 17 16:19:10 2014 +0000
> Commit:     David Mitchell <davem@iabyn.com>
> CommitDate: Mon Mar 17 16:35:07 2014 +0000
> 
>     tidy up kill0.t and kill0_child
>     
>     The previous commit added some tests to kill0.t, and added the auxiliary
>     file kill0_child. Tidy up the new code to better match normal standards.
>     In particular, improve the format, grammar and clarity of the comments,
>     and replace q|...| with "..." where appropriate.
>     Also, make the temporary filename a variable, and prefix it with "tmp-",
>     so that if gets left around for any reason, it's more obvious that it's
>     just an extraneous temporary file.
>     
>     (I haven't actually tested this commit on win32)
> 
> 
> 

http://www.nntp.perl.org/group/perl.daily-build.reports/2014/03/msg159824.html the test is failing on Geroge smoker. I fetched a new blead and reran it on my machine and ../t/op/kill0.t passes. The kill() calls fail. What is unusual is that there is no "not ok 9999" or out of sequence reports in the report, so I presume the child procs never got CPU time even though they got PIDs or were actually killed on an OS level and something went wrong in the win32_killpg. The only idea I have right now is to increase the sleep 5 to 15 in http://perl5.git.perl.org/perl.git/blob/HEAD:/t/op/kill0_child .


-- 
bulk88 ~ bulk88 at hotmail.com

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=121230

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About