Front page | perl.perl5.porters |
Postings from March 2014
On Mon Mar 17 09:40:43 2014, davem wrote: > Thanks, applied as af728ca1bc. I also took the libery of cleaning the code > up a bit with the following commit: > > commit 4c0e595c606032a1e1c0a922399a1e7bd2358ca9 > Author: David Mitchell <davem@iabyn.com> > AuthorDate: Mon Mar 17 16:19:10 2014 +0000 > Commit: David Mitchell <davem@iabyn.com> > CommitDate: Mon Mar 17 16:35:07 2014 +0000 > > tidy up kill0.t and kill0_child > > The previous commit added some tests to kill0.t, and added the auxiliary > file kill0_child. Tidy up the new code to better match normal standards. > In particular, improve the format, grammar and clarity of the comments, > and replace q|...| with "..." where appropriate. > Also, make the temporary filename a variable, and prefix it with "tmp-", > so that if gets left around for any reason, it's more obvious that it's > just an extraneous temporary file. Everything is fine in that except 1 thing. Why replace the single quotes with double quotes for the sake of using double quotes? I've always assume double quotes take longer for the compiler to parse than single quotes, and using double quotes without knowing why leads to a larger change of unintended code execution/interpolation. -- bulk88 ~ bulk88 at hotmail.com --- via perlbug: queue: perl5 status: open https://rt.perl.org/Ticket/Display.html?id=121230Thread Previous | Thread Next