develooper Front page | perl.perl5.porters | Postings from March 2014

Re: [perl #121230] process group kill on Win32 broken in 5.17.2,regression 5.18

Thread Previous | Thread Next
From:
Dave Mitchell
Date:
March 17, 2014 16:40
Subject:
Re: [perl #121230] process group kill on Win32 broken in 5.17.2,regression 5.18
Message ID:
20140317163823.GI1615@iabyn.com
On Fri, Feb 28, 2014 at 08:59:15PM -0800, bulk88 via RT wrote:
> I don't think I will get a response. So it stays at 5 seconds and a new
> patch mentioning 5.18.0 instead of 5.17.2 is attached.

Thanks, applied as af728ca1bc. I also took the libery of cleaning the code
up a bit with the following commit:

commit 4c0e595c606032a1e1c0a922399a1e7bd2358ca9
Author:     David Mitchell <davem@iabyn.com>
AuthorDate: Mon Mar 17 16:19:10 2014 +0000
Commit:     David Mitchell <davem@iabyn.com>
CommitDate: Mon Mar 17 16:35:07 2014 +0000

    tidy up kill0.t and kill0_child
    
    The previous commit added some tests to kill0.t, and added the auxiliary
    file kill0_child. Tidy up the new code to better match normal standards.
    In particular, improve the format, grammar and clarity of the comments,
    and replace q|...| with "..." where appropriate.
    Also, make the temporary filename a variable, and prefix it with "tmp-",
    so that if gets left around for any reason, it's more obvious that it's
    just an extraneous temporary file.
    
    (I haven't actually tested this commit on win32)



-- 
"Strange women lying in ponds distributing swords is no basis for a system
of government. Supreme executive power derives from a mandate from the
masses, not from some farcical aquatic ceremony."
    -- Dennis, "Monty Python and the Holy Grail"

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About