develooper Front page | perl.perl5.porters | Postings from March 2014

Re: lib/locale.t warnings

Thread Previous | Thread Next
From:
Niko Tyni
Date:
March 1, 2014 11:16
Subject:
Re: lib/locale.t warnings
Message ID:
20140301111550.GA5346@estella.local.invalid
On Fri, Feb 28, 2014 at 12:34:14PM -0700, Karl Williamson wrote:
> On 02/28/2014 08:27 AM, Dave Mitchell wrote:

> >PS there seems to be a strange idiom in run/locale.t:
> >
> >     for ($different) {
> >	local $ENV{LC_NUMERIC} = $_;
> >         ... code that doesn't use $_ ...
> >     }
> >
> >I can't see why it isn't simply written as
> >
> >     {
> >	local $ENV{LC_NUMERIC} = $different;
> >         ... code that doesn't use $_ ...
> >     }
> >
> 
> As for my commits, I just cargo-culted what was already there.  Some
> seem to date from 903eb63f 	

That would be me. I suspect there used to be more references to to $_ at
some point when I developed the tests, and I just missed cleaning that up
before submitting the patch.  Feel free to fix it :)
-- 
Niko Tyni   ntyni@debian.org

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About