develooper Front page | perl.perl5.porters | Postings from March 2014

[perl #121119] [PATCH] speed up miniperl @INC searching, buildcustomize

Thread Previous | Thread Next
From:
bulk88 via RT
Date:
March 1, 2014 02:53
Subject:
[perl #121119] [PATCH] speed up miniperl @INC searching, buildcustomize
Message ID:
rt-4.0.18-22881-1393642420-1879.121119-15-0@perl.org
On Sun Feb 09 18:18:03 2014, bulk88 wrote:
> 
> patches used for testing
> 
> -----------------------------------------------------------------------------------------
> win32/win32.h | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/win32/win32.h b/win32/win32.h
> index 3d1655a..f5f0187 100644
> --- a/win32/win32.h
> +++ b/win32/win32.h
> @@ -20,6 +20,7 @@
>   * level in full perl
>   */
>  #  define WIN32_NO_SOCKETS
> +#  define PERL_DISABLE_PMC
>  #endif
> 
> #ifdef WIN32_NO_SOCKETS
> 
> ----------------------------------------------------------------------------------------
> write_buildcustomize.pl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/write_buildcustomize.pl b/write_buildcustomize.pl
> index 64bf4ce..181a00b 100644
> --- a/write_buildcustomize.pl
> +++ b/write_buildcustomize.pl
> @@ -54,7 +54,7 @@ require File::Spec::Functions;
> 
> my $inc = join ",\n        ",
>     map { "q\0$_\0" }
> -    (map {File::Spec::Functions::rel2abs($_)} @toolchain, 'lib');
> +    (map {File::Spec::Functions::rel2abs($_)} 'lib', @toolchain);
> 
> open my $fh, '>', $file
>     or die "Can't open $file: $!";
> @@ -74,6 +74,8 @@ print $fh <<"EOT" or $error = "Can't print to $file:
> $!";
> # We are miniperl, building extensions
> # Replace the first entry of \@INC ("lib") with the list of
> # directories we need.
> +
> +\${^WIN32_SLOPPY_STAT} = 1;
> splice(\@INC, 0, 1, $inc);
> \$^O = '$osname';
> EOT

To get this ticket moving. So I will make a patch with all 3 optimizations above, and all 3 optimizations are done only on Win32? With all the discussion above, AFAIK the consensus is none of the 3 optimizations can be done on anything but Win32. Any final objections to the proposal in this post that would prevent the future patch from being applied?

-- 
bulk88 ~ bulk88 at hotmail.com

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=121119

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About