Re: [perl #118477] [PATCH] Add an API to attach a signature stringto a CV

On Fri, Jun 14, 2013 at 04:47:03AM -0700, Peter Martini wrote:

> In the branch https://github.com/PeterMartini/perl/tree/signatures/magic-api,
> I added:
> 
> * A new type of magic to store a sub signature
> * cv_set_signature_pv(CV * cv, SV * pv) as a static inline function
> instead of using the magic directly
> * cv_get_signature_pv(CV * cv) as a static inline function to return
> the signature
> * Two functions in XS::APITest and
> * B::CV::get_signature to give B modules access to it (a separate commit)
> * B::Deparse patched to use B::CV::get_signature (a separate commit)
> 
> The Deparse output will display the prototype as a 'prototype()'
> attribute if both a signature string and a prototype are attached; I
> don't have a patch ready for that yet, but will in the next few days.
> 
> Please review.

There was review of this specific patch.

However, is this patch and ticket now superceded, and can it be rejected?

Nicholas Clark

• [perl #118477] [PATCH] Add an API to attach a signature string to a CV by Father Chrysostomos via RT
• [perl #118477] [PATCH] Add an API to attach a signature string to a CV by James E Keenan via RT
• [perl #118477] [PATCH] Add an API to attach a signature string to a CV by Peter Martini via RT
• Re: [perl #118477] [PATCH] Add an API to attach a signature stringto a CV by Steffen Mueller
• [perl #118477] [PATCH] Add an API to attach a signature string to a CV by Peter Martini via RT
• Re: [perl #118477] [PATCH] Add an API to attach a signature stringto a CV by Steffen Mueller
• [perl #118477] [PATCH] Add an API to attach a signature string to a CV by Peter Martini
• Re: [perl #118477] [PATCH] Add an API to attach a signature stringto a CV by Nicholas Clark
• Re: [perl #118477] [PATCH] Add an API to attach a signature string to a CV by Peter Martini