develooper Front page | perl.perl5.porters | Postings from January 2014

[perl #115660] version->parse missing mg_get

Thread Previous
From:
bulk88 via RT
Date:
January 24, 2014 12:27
Subject:
[perl #115660] version->parse missing mg_get
Message ID:
rt-4.0.18-32381-1390566425-401.115660-15-0@perl.org
On Fri Nov 09 11:49:44 2012, ikegami@adaelis.com wrote:
> This is a bug report for perl from ikegami@adaelis.com,
> generated with the help of perlbug 1.39 running under perl 5.16.1.
> 
> 
> -----------------------------------------------------------------
> [Please describe your issue here]
> 
> 
> version->parse (which is to say XS_version_new in universal.c) doesn't
> call
> mg_get before checking if its argument is defined as it should.
> 
> $ perl -Mversion -E'
>     "v1.00" =~ /v(.+)/ or die;
>     $x=$1 if $ARGV[0];
>     say version->parse($1);
> ' 0
> 0
> 
> $ perl -Mversion -e'
>     "v1.00" =~ /v(.+)/ or die;
>     $x=$1 if $ARGV[0];
>     say version->parse($1);
> ' 1
> 1.00
> 
> Workaroud:
> 
> $ perl -Mversion -E'
>     "v1.00" =~ /v(.+)/ or die;
>     say version->parse("$1");
> '
> 1.00
> 
> 

--------------------------------------------
C:\Documents and Settings\Owner\Desktop\cpan libs\version>perl -Mversion -E"\"v1
.00\" =~ /v(.+)/ or die;        $x=$1 if $ARGV[0]; say version->parse($1);" 0
1.00

C:\Documents and Settings\Owner\Desktop\cpan libs\version>perl -Mversion -E"\"v1
.00\" =~ /v(.+)/ or die;        $x=$1 if $ARGV[0]; say version->parse($1);" 1
1.00

C:\Documents and Settings\Owner\Desktop\cpan libs\version>
--------------------------------------------
This was fixed in http://perl5.git.perl.org/perl.git/commit/0c1d6ad7c56336f44f5ca9213891dc048565bb49?f=universal.c in blead, which came from https://bitbucket.org/jpeacock/version/commits/6fd396e1006b2190317035f3272128f9ed34098a  which claimed to fix https://rt.cpan.org/Public/Bug/Display.html?id=87983 

There are still outstanding issues that I raised in https://rt.perl.org/Ticket/Display.html?id=115660#txn-1169402 so this can't be closed yet. I'll try to get to them today and submit upstream.


-- 
bulk88 ~ bulk88 at hotmail.com

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=115660

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About