On Sat Dec 21 20:25:13 2013, bulk88 wrote: > On Sat Dec 21 18:07:08 2013, sprout wrote: > > > > Could someone else familiar with ops review my suggestions? > > > > Should I > > • make all ops store line numbers, fixing numerous bugs and > > increasing memory usage, > > • introduce a new SUBOP op type that includes a line number or > > • make PL_copline localisation only protect the inner value, not > > the outer? > > > > I suggest won't fix. IMO line numbers are on a statement, not > expression/substatement basis. None of the suggestions sound like the > increase in memory or CPU will justify a bug about undocumented and > subject to change behavior. I did think of something, what if a single bit in the op struct indicated if this op is on a new line, or previous line. The line number of the current op * is determined by walking from the COP along the the linked list to the current op * and counting the number of newline bits. The algorithm for computing the line number is very overhead intensive/slow, but takes very very little memory, just 1 bit per op struct. -- bulk88 ~ bulk88 at hotmail.com --- via perlbug: queue: perl5 status: open https://rt.perl.org/Ticket/Display.html?id=119593Thread Previous | Thread Next