develooper Front page | perl.perl5.porters | Postings from October 2013

Re: [perl #120406] [PATCH] Documentation Patches

Thread Previous | Thread Next
From:
Craig A. Berry
Date:
October 31, 2013 13:51
Subject:
Re: [perl #120406] [PATCH] Documentation Patches
Message ID:
CA+vYcVyDndGE-SO2MG1iC=6cW72+mQ8hnriWdddj6gn3XuSmBw@mail.gmail.com
On Thu, Oct 31, 2013 at 6:53 AM, Dave Mitchell <davem@iabyn.com> wrote:

> Now, whether RT used to be able to process these mis-formatted MIME
> emails, and since the recent upgrade to RT, has ceased to do so, I don't
> know. Can anyone with a better understanding of MIME or how things used to
> work chip in?

I know zilch about both MIME and RT, but I'm still paying down the
debt from all the mangled patches that Sarathy and Jarkko and Rafael
and others have had to unmangle for me over the years, so I thought
I'd have a look.

I didn't find it at all difficult to apply Tom's patch.  In Gmail I
just did "Show Original" then "Save As" in Safari, then "git am" on
the saved file.  I did then have to do git commit --amend to edit the
commit message, which had ended up with a lot of extraneous junk from
RT in it, and I had to fix the author because it wanted to make
perlbug, not Tom, the author.  I don't know how much of that is
"normal" because I don't apply patches from RT much.

All of which took far less time than writing this e-mail, and would've
been faster if I would actually take the time to learn vi instead of
stumbling around doing everything with the arrow keys.  So to anyone
thinking of not sending patches because it's too difficult to get them
in, sorry, you're still on the hook :-).

Getting RT and git format-patch to understand each other better would
be nice, if that is indeed where the problem is, but I see no major
problem here.

And Tom, thanks, applied as
<http://perl5.git.perl.org/perl.git/commit/cdf6c183dbf7f41c371d58b0e8c0ec251c11da91>.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About