Front page | perl.perl5.porters |
Postings from October 2013
Re: [perl #120406] [PATCH] Documentation Patches
Thread Previous
|
Thread Next
From:
Dave Mitchell
Date:
October 31, 2013 11:54
Subject:
Re: [perl #120406] [PATCH] Documentation Patches
Message ID:
20131031115357.GA14507@iabyn.com
On Thu, Oct 31, 2013 at 08:35:27AM +0000, Tom Hukins wrote:
> On Wed, Oct 30, 2013 at 03:54:46PM -0700, James E Keenan via RT wrote:
> > Thanks for the patches.
>
> You're welcome.
>
> > However, would it be possible for you to re-post them as
> > *attachments*, either to an email or to a new post to the RT #120406
> > GUI? (And, preferably, one attachment for each patch.)
>
> I followed the instructions of the "Super Quick Patch Guide" in
> perlhack.pod from blead.
>
> Please let me know when you have updated these instructions to
> correctly explain how contributors should submit patches, then I will
> resubmit my work.
I think its an issue at this end. The instructions suggest using
git format-patch with the -attach option, which outputs the 0001-foo
file with embedded MIME info. This is then included in the email that
perlbug generates. However, since the email header itself doesn't include
any relevant MIME headers, the email as a whole isn't interpreted
as being MIME, and certainly my mail client (mutt) doesn't "see" the
attachments in a test perlbug I just CC'ed to myself, and neither does RT.
The commit that added the '--attach' is this one from two years ago:
commit 5c70016eb3bb7b430ef912d422b3d2727c118336
Author: Jim Cromie <jim.cromie@gmail.com>
AuthorDate: Tue May 31 10:47:29 2011 -0600
perlhack.pod: invoke git-format-patch with --attach
As George Greer noted on p5p, --attach causes the message to be
written using MIME-attach syntax, so when perlbug sends it,
rt.perl.org detaches the file and adds it to the ticket.
While tradtional inline patches appear to survive without whitespace
mangling, attachments are more in keeping with RTs design and use.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
diff --git a/pod/perlhack.pod b/pod/perlhack.pod
index f8f8bdd..6f5ea73 100644
--- a/pod/perlhack.pod
+++ b/pod/perlhack.pod
@@ -56,10 +56,11 @@ sentence. For example, "Fixed spelling errors in perlhack.pod".
The next step is to submit your patch to the Perl core ticket system
via email.
-Assuming your patch consists of a single git commit, you can send it to
-perlbug with this command line:
+Assuming your patch consists of a single git commit, the following
+writes the file as a MIME attachment, and sends it with a meaningful
+subject:
- % git format-patch -1
+ % git format-patch -1 --attach
Now, whether RT used to be able to process these mis-formatted MIME
emails, and since the recent upgrade to RT, has ceased to do so, I don't
know. Can anyone with a better understanding of MIME or how things used to
work chip in?
--
Counsellor Troi states something other than the blindingly obvious.
-- Things That Never Happen in "Star Trek" #16
Thread Previous
|
Thread Next