develooper Front page | perl.perl5.porters | Postings from October 2013

[perl #120406] [PATCH] Documentation Patches

Thread Next
bulk88 via RT
October 31, 2013 04:25
[perl #120406] [PATCH] Documentation Patches
Message ID:
On Wed Oct 30 17:12:19 2013, jkeenan wrote:
> No, that's not acceptable.  I still have to copy-and-paste.  And in
> the majority of the instances where I try that, I get a result like
> this:
> #####
> $ git am < ~/p5p/120406-perlfunc.patch
> Applying: Refer to the correct section
> fatal: corrupt patch at line 21
> Patch failed at 0001 Refer to the correct section
> #####
> Attaching a patch, rather than pasting it inline, makes it easier for
> volunteers like me to apply the patch.
> Thank you very much.
> Jim Keenan

AFAIK, git am only takes git patches, with lines like "index 1c2eeb3..aacf05b 100644". It doesn't take diff patches that start with
--- C:\perl519\perl.h 
+++ C:\perl512\perl.h 
@@ -22,6 +22,15 @@"

I'm not sure git can decode the MIME either in this ticket. I would think an email client would save 2 files to disk, and git will then apply 2 .patch files from disk. git isn't an email client. The man has a very detailed explanation of what the patch should look like.

bulk88 ~ bulk88 at

via perlbug:  queue: perl5 status: open

Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About