develooper Front page | perl.perl5.porters | Postings from October 2013

Re: Padlist NULL pointer?

Thread Previous | Thread Next
From:
Darin McBride
Date:
October 30, 2013 13:29
Subject:
Re: Padlist NULL pointer?
Message ID:
1749488.SA6fv6gPlv@naboo
On Wednesday October 30 2013 1:00:51 PM Father Chrysostomos wrote:
> Darin McBride wrote:
> > I'm just looking for where a
> > patch may be required to stop the seg fault.
> 
> Does this work?  I have not tested it yet.

Yes, this seems to do it, at least for all the test cases I have so far.  (I'm 
near the beginning of a new project, so I have many many test cases not 
written for many chunks of code also not written.)

> diff -rup Coro-6.31-eL_b57-orig/Coro/State.xs Coro-6.31-eL_b57/Coro/State.xs
> --- Coro-6.31-eL_b57-orig/Coro/State.xs2013-10-30 05:56:32.000000000 -0700
> +++ Coro-6.31-eL_b57/Coro/State.xs2013-10-30 05:56:43.000000000 -0700 @@
> -513,7 +513,7 @@ coro_derive_padlist (pTHX_ CV *cv)
>    PADLIST *padlist = CvPADLIST (cv);
>    PADLIST *newpadlist;
>    PAD *newpad;
> -  PADOFFSET const off = PadlistMAX (padlist) + 1;
> +  PADOFFSET const off = CvDEPTH (cv) ? CvDEPTH (cv) + 1 : 2;
> 
>    newPADLIST(newpadlist);
>  #if !PERL_VERSION_ATLEAST(5,15,3)
> 
> If you look in Coro’s Changes file, you will see this:
> 
>         - implement 5.17 compatibility by almost blindly applying a
>           good-looking patch by Father Chrysostomos.
> 
> So it’s my fault, for submitting a faulty patch.

I'm not looking for blame. I'm looking for a fix.  :)  I will pass this along 
to Marc and see if he's amenable to the fix.  Thanks!
Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About