develooper Front page | perl.perl5.porters | Postings from October 2013

Re: When is PL_curcop NULL?

Thread Previous
From:
Nicholas Clark
Date:
October 17, 2013 18:02
Subject:
Re: When is PL_curcop NULL?
Message ID:
20131017180230.GI26894@plum.flirble.org
On Fri, Sep 20, 2013 at 09:13:21AM -0000, Father Chrysostomos wrote:
> Nicholas Clark wrote:
> > On Tue, Aug 06, 2013 at 01:11:56PM -0000, Father Chrysostomos wrote:
> > > I tried adding that block locally and *also* adding assert(PL_curcop)
> > > to newGP, and got no failures.  I think that both are a good idea.  We
> > > have many months before the next stable release and plenty of time to
> > > smoke out places where that assertion is wrong.  (And we will leave
> > > the null checks in newGP for now anyway, so non-debugging builds are
> > > not sabotaged.)
> 
> I implemented that in commit f5d98eaa982e2.  It turns out to be work-
> ing so far, because DBIx::Class is failing that assertion.  I have
> reduced it to:
> 
> INIT {
>   eval { eval { sub { die bless {} }->() } }
>     or exit;
> }
> 
> but I have not looked any further yet.

I don't think that you noted in this thread that you did look further,
resulting in this commit:

Author: Father Chrysostomos <sprout@cpan.org>
Date:   Sat Sep 21 07:43:12 2013 -0700

    Remove bad assertion in gv.c:newGP


So I have just noted this. :-)

Thanks for digging into this, and finding a definitive answer.

Nicholas Clark

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About