Front page | perl.perl5.porters |
Postings from October 2013
On Wed, Oct 2, 2013 at 7:49 AM, James E Keenan via RT <perlbug-followup@perl.org> wrote: > On Tue Oct 01 16:14:07 2013, jkeenan wrote: >> On Tue Oct 01 06:22:40 2013, sprout wrote: >> > On Mon Sep 30 23:07:32 2013, pcm wrote: >> > > s/true/TRUE/, and fixed the leaking *proto. >> > >> > Thank you. That looks good to me. I can’t actually test it myself >> > right now, but if the tests pass for some other committer, then it >> > gets >> > my +1. >> > >> > The latest versions of the two patches I believe are now: >> > >> > https://rt.perl.org/rt3/Ticket/Attachment/1255913/657647/0001-perl- >> > 119251-Add-a-prototype-attribute-to-attributes..patch >> > https://rt.perl.org/rt3/Ticket/Attachment/1259533/660375/0001-perl- >> > 119251-Handle-the-prototype-attribute-during-su.patch >> > >> >> >> I have applied those two patches to a branch and pushed it to smoke: >> smoke-me/jkeenan/119251-prototype > > One Win32 build failure has already been reported to p5p list. Works > fine on Darwin/PPC. > > --- > via perlbug: queue: perl5 status: open > https://rt.perl.org:443/rt3/Ticket/Display.html?id=119251 Ah, thanks for the smoke-me run. I looked at it and I can clearly see my first patch wasn't strict C89 (I add two declarations after code), and apparently the attributes module isn't being compiled with strict mode (?). Or at least, it passed on my computers, where C89 strict is an option, but failed on the Win2k smoker, which I guess was automatically C89. Attaching a very slightly modified version of the first patch, which just moves the if(..) Perl_croak down two lines. Can this be set to smoke instead?Thread Previous | Thread Next