develooper Front page | perl.perl5.porters | Postings from September 2013

Re: [perl #119251] [PATCH] Enhancement request - a prototype attribute

Thread Previous | Thread Next
From:
Peter Martini
Date:
September 30, 2013 06:31
Subject:
Re: [perl #119251] [PATCH] Enhancement request - a prototype attribute
Message ID:
CAFyW6MRwUpsxt5aMXeCbtaFEpSQ9hxX4OR++Ve8ZoN73XJtDEQ@mail.gmail.com
The last issues I'd noted were removing the '*' from a GV if it hits
the attributes module, which the last version of the attributes patch
did (https://rt.perl.org/rt3/Ticket/Attachment/1244083/649157/0001-perl-119251-Added-a-prototype-attribute-to-attributes.xs.patch),
and not crashing on a syntax error.  The attached patch fixes the
crashing on syntax error part by not calling move_proto_attr if there
were any errors compiling the sub, as that's the only case (right?)
where there would not be a name.

(And I did look into a cv_name function, but I'm not sure where the
best place to put it would be).

It's late, so I may be overlooking things.  If I forgot something
obvious, sorry, just wanted to get the ball rolling again!

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About