develooper Front page | perl.perl5.porters | Postings from September 2013

[perl #119945] [PATCH] 4e51d69 Fixed bug where is_core assumed linear release sequence

Thread Previous | Thread Next
From:
Neil Bowers
Date:
September 23, 2013 22:02
Subject:
[perl #119945] [PATCH] 4e51d69 Fixed bug where is_core assumed linear release sequence
Message ID:
rt-3.6.HEAD-1873-1379891113-859.119945-75-0@perl.org
# New Ticket Created by  Neil Bowers 
# Please include the string:  [perl #119945]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=119945 >


Somewhat embarrassingly my first core module patch had a bug in it: if you specify a minimum version for the module, I traverse through releases, seeing if an acceptable version was released upto and including the specified release of Perl. But I was traversing the sequence of releases as if they were a linear sequence.

This fix now traverse the branch on the release tree leading to the specified version of perl.
An example where this resulted in the wrong behaviour, for Text::Soundex is illustrated in this blog post:

http://neilb.org/2013/09/21/adding-is-core.html

Added tests for this example, and a couple more tests for good measure.

Neil


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About