develooper Front page | perl.perl5.porters | Postings from September 2013

Re: [perl #119769] skip lib/ExtUtils/t/Embed.t when cross-compiling

Thread Previous | Thread Next
From:
François Perrad
Date:
September 23, 2013 11:38
Subject:
Re: [perl #119769] skip lib/ExtUtils/t/Embed.t when cross-compiling
Message ID:
CAB0FRsvMULXQmqhNtQQoAnvVQm6T44dFOLT0Ho_iq47DQPsHzw@mail.gmail.com
2013/9/17 Brian Fraser <fraserbn@gmail.com>:
> On Fri, Sep 13, 2013 at 4:35 AM, Francois PERRAD <perlbug-followup@perl.org>
> wrote:
>>
>> # New Ticket Created by  Francois PERRAD
>> # Please include the string:  [perl #119769]
>> # in the subject line of all future correspondence about this issue.
>> # <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=119769 >
>>
>>
>> This is a bug report for perl from francois.perrad@gadz.org,
>> generated with the help of perlbug 1.39 running under perl 5.18.1.
>>
>>
>> -----------------------------------------------------------------
>> [Please describe your issue here]
>>
>> The toolchain is not installed on the target when cross-compiling.
>> So, this test must be skipped, see patch below.
>>
>> (info for dual life modules with same issue :
>> - ExtUtils-MakeMaker : see
>> https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/pull/69,
>> merged and shipped with 6.77_02
>> - Module-Builder : see
>> https://github.com/Perl-Toolchain-Gang/Module-Build/pull/30
>> - ExtUtils-Constant : see https://rt.cpan.org/Ticket/Display.html?id=88645
>> - ExtUtils-Install : see https://rt.cpan.org/Ticket/Display.html?id=88644
>> )
>>
>> diff --git a/lib/ExtUtils/t/Embed.t b/lib/ExtUtils/t/Embed.t
>> index 7a83c98..380ae93 100644
>> --- a/lib/ExtUtils/t/Embed.t
>> +++ b/lib/ExtUtils/t/Embed.t
>> @@ -12,6 +12,10 @@
>>  use ExtUtils::Embed;
>>  use File::Spec;
>>
>> +if ( $Config{'usecrosscompile'} ) {
>> +    print "1..0 # SKIP no toolchain installed when cross-compiling\n";
>> +    exit 0;
>> +}
>>  open(my $fh,">embed_test.c") || die "Cannot open embed_test.c:$!";
>>  print $fh <DATA>;
>>  close($fh);
>> --
>> 1.7.9.5
>
>
>
> Pardons, dropped the ball on this one. I meant to reply before it got
> applied, but oh well.
>
> It's not necessarily true that the toolchain is not installed when
> cross-compiling. Particularly, with castaway's branch, it is installed, but
> generally useless *unless* the target OS does a bit of extra legwork to have
> all the proper binaries with the correct names in place.
> That might seem like a stretch, but I bet that a bunch of people on the list
> have a device that does exactly that: the Raspberry Pi. You cross-compile
> using arm-linux-gnueabihf-gcc, and the raspi itself provides a
> arm-linux-gnueabihf-gcc, which is a symlink to gcc.
>
> The applied patch isn't intrusive and does help the current
> cross-compilation situation, so no need to revert it or anything, but
> whenever castaway's branch is merged we can deal with this better, perhaps
> doing something like this:
> https://github.com/Hugmeir/utf8mess/commit/e4c8127787478ea81e5de0e6d358146940908433
>

well, looks better than my initial patch.

so, I improve my work with a new patch.

François

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About