develooper Front page | perl.perl5.porters | Postings from September 2013

Re: [perl #119869] [PATCH] WinCE Makefile and make_ext.pl generaland XS fixes

Thread Previous
From:
Nicholas Clark
Date:
September 20, 2013 09:30
Subject:
Re: [perl #119869] [PATCH] WinCE Makefile and make_ext.pl generaland XS fixes
Message ID:
20130920093035.GL66035@plum.flirble.org
On Thu, Sep 19, 2013 at 12:11:56AM -0700, bulk88 via RT wrote:

> That is a mistake. Should I remove the eval form use constant and do it
> as you suggested, or not use constant at all and roll my own to avoid
> the overhead of "use constant" since that module hasn't been used before
> in make_ext.pl, example below
> 
> BEGIN {
>       eval 'sub IS_CROSS() { '.(defined $::Cross::platform ? 1 : 0).' }';

I'd suggest using constant, as I think that it's clearer to anyone reading
the code. It's already available to the build process, as it's stuffed into
@INC by lib/buildcustomize.pl

Nicholas Clark

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About