develooper Front page | perl.perl5.porters | Postings from September 2013

Re: [perl #89502] Add support for Atari FreeMiNT platform

Thread Previous | Thread Next
From:
H.Merijn Brand
Date:
September 17, 2013 07:00
Subject:
Re: [perl #89502] Add support for Atari FreeMiNT platform
Message ID:
20130917090040.7cc56dd6@pc09.procura.nl
On Mon, 16 Sep 2013 14:16:02 -0700, "Alan Hourihane via RT"
<perlbug-followup@perl.org> wrote:

> On Fri Apr 29 03:19:00 2011, hmbrand wrote:
> > On Thu, 28 Apr 2011 20:37:05 +0100, Alan Hourihane
> > <alanh@fairlite.co.uk> wrote:
> > 
> > > Here's the patch.
> > 
> > Sorry to say it is just too late for 5.14.0
> > 
> > 
> > 
> > --- perl-5.12.3/Configure	2011-02-21 09:18:09.000000000 +0000
> > +++ perl-5.12.3-mint/Configure	2011-02-21 09:38:49.000000000 +0000
> > @@ -1275,6 +1275,9 @@
> >  elif test -n "$DJGPP"; then
> >  : DOS DJGPP
> >      _exe=".exe"
> > +elif test -f "/kern/cookiejar"; then
                  ^               ^

As part of the original patch is about quotes, I might add that those
are not needed here, right?

> > +: MiNT
> > +    _exe=""
> >  elif test -d c:/. -o -n "$is_os2" ; then
> >  : OS/2 or cygwin
> >      _exe=".exe"
> > 
> > Why exactly is this needed? As "" is the default. What other test would
> > trigger it to be something else, and in that case, could that other
> > test be amended by adding criteria?
> > 
> > @@ -1402,7 +1405,7 @@
> >  	xcat=/bin/cat
> >  	test -f $xcat$_exe || xcat=/usr/bin/cat
> >  	if test ! -f $xcat$_exe; then
> > -		for p in `echo $PATH | sed -e "s/$p_/ /g"` $paths; do
> > +		for p in `echo $PATH | sed -e 's/$p_/ /g'` $paths; do
> >  			if test -f $p/cat$_exe; then
> >  				xcat=$p/cat
> >  				break
> > 
> > Looks sane, but again not in time for 5.14.0. This is btw an unchanged
> > item from the original "dist" metaconfig package. I'll contact Rafa´┐Żl
> > (the maintainer of dist) for his opinion, as that unit is still
> > unchanged in his svn repo. (git++ for giving me git svn clone)
> > 
> > > Thanks,
> > > Alan.
> 
> Just to go over the Configure patch again.
> 
> The first hunk is required because otherwise the OS2/Cygwin test
> succeeds on this platform, and that's incorrect.
> 
> The second hunk isn't required. I've just retested without it.

Then do not change it. This is most likely what was holding the patch
from being applied anyway. Here is the comments (slightly simplified)
from the maintainer of meta, just for some clarification:
--8<---
The correct line is of course the one that reads:

	for p in `echo $PATH | sed -e "s/$p_/ /g"` $paths; do

but this patch seems to prefer the one where the substitution pattern
would be enclosed in simple quotes. That is of course wrong, since the
then $p_ variable will not be expanded (p_ is the path separator, as
computed in Head.U).

In the SVN repository, the line present in spitshell.U is the correct one.
-->8---

> Can this be committed without that hunk ?

I think so

> Also, we need the above comment rectifying so we don't lose dld support.
> 
> Thanks.

-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.19   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/        http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About