develooper Front page | perl.perl5.porters | Postings from August 2013

[perl #119515] [PATCH] [DOCFIX] - DynaLoader references deprecated newXSUB

Thread Previous
From:
Father Chrysostomos via RT
Date:
August 30, 2013 19:54
Subject:
[perl #119515] [PATCH] [DOCFIX] - DynaLoader references deprecated newXSUB
Message ID:
rt-3.6.HEAD-1873-1377892434-1353.119515-15-0@perl.org
On Fri Aug 30 09:56:19 2013, nicholas wrote:
> On Fri, Aug 30, 2013 at 12:45:20PM -0400, Matthew Horsfall (alh)
> wrote:
> > On Fri, Aug 30, 2013 at 11:20 AM, Father Chrysostomos via RT <
> > perlbug-followup@perl.org> wrote:
> >
> > > On Fri Aug 30 04:43:57 2013, nicholas wrote:
> > > > >  The $filename parameter is used by Perl to identify the
> source file
> > > > for
> > > >
> > > > win32 seems to be the only code using newXS(). newXS() And
> > > > newXS_flags()
> > > > are both (now) wrappers to newXS_len_flags(), and possibly some
> of the
> > > > callers of newXS_flags() might change to the latter. So is it
> better
> > > > just
> > > > to word it as "newXS_len_flags() or one of its wrappers" ?
> > >
> > > No.  newXS_len_flags is not API.
> > >
> > >
> > Should we add it to the api and save the strlen call, or forget it
> and
> > document as is?
> >
> > Or is there another option?
> 
> I don't know. I'm dithering. It's ugly,

Thank you. :-)

> with too many parameters. But
> I think
> that they are all there for a reason. One question to ask is "how long
> has it
> been around,

032a04476225 in November of 2011.

> and are the parameters stable?" (ie, has there been need
> to
> change them).

8f82b567179d2 in the same month.

The parameter list is absolutely awful for an API.  I added that
function (I renamed newXS_flags and made it a wrapper) because
newXS_flags didn’t do what I needed.  The parameters are definitely
*not* stable.  Making them stable will just guarantee more wrappers in
the future, which all wrap around newXS_not_api_DONT_USE_OR_OSSIFY_THIS.

-- 

Father Chrysostomos


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=119515

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About