develooper Front page | perl.perl5.porters | Postings from August 2013

Re: [perl #119515] [PATCH] [DOCFIX] - DynaLoader referencesdeprecated newXSUB

Thread Previous | Thread Next
From:
Nicholas Clark
Date:
August 30, 2013 16:55
Subject:
Re: [perl #119515] [PATCH] [DOCFIX] - DynaLoader referencesdeprecated newXSUB
Message ID:
20130830165540.GZ66035@plum.flirble.org
On Fri, Aug 30, 2013 at 12:45:20PM -0400, Matthew Horsfall (alh) wrote:
> On Fri, Aug 30, 2013 at 11:20 AM, Father Chrysostomos via RT <
> perlbug-followup@perl.org> wrote:
> 
> > On Fri Aug 30 04:43:57 2013, nicholas wrote:
> > > >  The $filename parameter is used by Perl to identify the source file
> > > for
> > >
> > > win32 seems to be the only code using newXS(). newXS() And
> > > newXS_flags()
> > > are both (now) wrappers to newXS_len_flags(), and possibly some of the
> > > callers of newXS_flags() might change to the latter. So is it better
> > > just
> > > to word it as "newXS_len_flags() or one of its wrappers" ?
> >
> > No.  newXS_len_flags is not API.
> >
> >
> Should we add it to the api and save the strlen call, or forget it and
> document as is?
> 
> Or is there another option?

I don't know. I'm dithering. It's ugly, with too many parameters. But I think
that they are all there for a reason. One question to ask is "how long has it
been around, and are the parameters stable?" (ie, has there been need to
change them).

And what we have isn't on a hot path.
So there are likely better things to fix first.

Also, technically DynaLoader is the only thing outside of the top level
directory that doesn't need to care about API link restrictions, as it has
to be linked statically to the rest of perl. But it would be bad form to use
something that no-one else is supposed to use.

Nicholas Clark

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About