On Fri Aug 30 04:43:57 2013, nicholas wrote: > On Thu, Aug 29, 2013 at 07:15:12AM -0700, Matthew Horsfall wrote: > > > The DynaLoader documentation for dl_install_xsub says: > > > > This is simply a direct call to newXSUB(). > > > > It looks like newXSUB() was removed a long time ago. I've updated > the doc > > with: > > > > This is simply a direct call to newXS()/newXS_flags(). > > > > Attached is the patch. > > Good catch. > > > Subject: [PATCH] Replace reference to newXSUB with newXS. > > > > newXSUB hasn't been around for a long time > > --- > > ext/DynaLoader/DynaLoader_pm.PL | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ext/DynaLoader/DynaLoader_pm.PL > b/ext/DynaLoader/DynaLoader_pm.PL > > index c67b4ab..03d45d1 100644 > > --- a/ext/DynaLoader/DynaLoader_pm.PL > > +++ b/ext/DynaLoader/DynaLoader_pm.PL > > @@ -870,7 +870,7 @@ Syntax: > > > > Create a new Perl external subroutine named $perl_name using > $symref as > > a pointer to the function which implements the routine. This is > simply > > -a direct call to newXSUB(). Returns a reference to the installed > > +a direct call to newXS()/newXS_flags(). Returns a reference to the > installed > > function. > > > > The $filename parameter is used by Perl to identify the source file > for > > win32 seems to be the only code using newXS(). newXS() And > newXS_flags() > are both (now) wrappers to newXS_len_flags(), and possibly some of the > callers of newXS_flags() might change to the latter. So is it better > just > to word it as "newXS_len_flags() or one of its wrappers" ? No. newXS_len_flags is not API. -- Father Chrysostomos --- via perlbug: queue: perl5 status: open https://rt.perl.org:443/rt3/Ticket/Display.html?id=119515Thread Previous | Thread Next