develooper Front page | perl.perl5.porters | Postings from August 2013

Re: S_is_safe_syscall and SvOK (Re: [perl.git] branch blead, updated. v5.19.3-130-gc8028aa)

Thread Previous
From:
Father Chrysostomos
Date:
August 30, 2013 05:06
Subject:
Re: S_is_safe_syscall and SvOK (Re: [perl.git] branch blead, updated. v5.19.3-130-gc8028aa)
Message ID:
20130830050649.24413.qmail@lists-nntp.develooper.com
Reini Urban wrote:
> The cases where this macro is applied throughout the code already asserted that
> the sv is a valid PV passed to a syscall, it cannot be PL_sv_undef.
> If it is it will blow up in the SvPVX(sv) call to the syscall, and has
> nothing to do with this check.

I have just looked at every instance of the macro, and what you say is
simply untrue.  The only case where the passed SV is guaranteed to be
POK is in pp_ctl.c:check_type_and_open when called by doopen_pm for
.pmc files.

This type of mistake is typical of most of your messages.  If you
could check your facts more carefully before sending, you might be
taken more seriously.


Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About