develooper Front page | perl.perl5.porters | Postings from August 2013

moving a Call Back Unit into Configure. Bad plan?

Thread Next
From:
Nicholas Clark
Date:
August 23, 2013 19:38
Subject:
moving a Call Back Unit into Configure. Bad plan?
Message ID:
20130823193801.GF74204@plum.flirble.org
I'm not sure if this is a great idea:

On Fri, Aug 23, 2013 at 05:31:03PM +0200, Nicholas Clark wrote:

> - Log -----------------------------------------------------------------
> commit 4a3e97a030d2e5767f5d320cecdb2a7a3a72606b
> Author: Nicholas Clark <nick@ccl4.org>
> Date:   Fri Aug 23 16:32:08 2013 +0200
> 
>     Move the thrice-repeated "64bitint is buggy?" test from hints to Configure.
>     
>     OpenBSD and its two* forks each have the same "is 64 bit int support buggy?"
>     test code as a callback unit duplicated in their hints files. As the code is
>     portable C, there seems to be no harm in moving it to Configure, and running
>     the test on all platforms. This reduces code duplication, and will reduce it
>     further if another OpenBSD fork appears.
>     
>     * This week.
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  Configure        | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  hints/bitrig.sh  | 59 --------------------------------------------------------
>  hints/mirbsd.sh  | 59 --------------------------------------------------------
>  hints/openbsd.sh | 59 --------------------------------------------------------
>  4 files changed, 53 insertions(+), 177 deletions(-)

but the stats are oh so tempting. The test code in question works (at least
for me) on Linux, FreeBSD, Solaris, AIX and HP-UX, so it seems to be
portable enough to live in Configure.

Given that BSDs seem to be breeding like rabbits* it seems to be a sensible
move in case there's a third OpenBSD fork.

Nicholas Clark

* credit Leon Timmermans for that analogy. It feels sadly apt :-(

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About