develooper Front page | perl.perl5.porters | Postings from August 2013

Re: the GitHub perl mirror

Thread Previous | Thread Next
From:
Christian Walde
Date:
August 20, 2013 09:05
Subject:
Re: the GitHub perl mirror
Message ID:
op.w13x6hulydyjqt@digitizedsqueak
On Mon, 19 Aug 2013 20:02:06 +0200, Jan Dubois <jand@activestate.com>  
wrote:

> On Mon, Aug 19, 2013 at 10:55 AM, Nicholas Clark <nick@ccl4.org> wrote:
>> On Mon, Aug 19, 2013 at 10:23:32AM -0700, Jan Dubois wrote:
>>> And as long as you eventually push this commit back to blead, the pull
>>> request should be closed automatically (the SHA1 needs to remain for
>>> Github to recognize it automatically).
>>
>> Which implies that if the commit is rebased to avoid the trivial merge,
>> that automatic close no longer works?
>
> Yes, that is unfortunately (?) correct.  So either the PR author
> rebases and makes a new PR

That's not necessary. The author can just rebase on their own, force-push  
the branch and github will update the pull request and allow auto-closing  
by way of fast-forward merge.

Additionally, it is also important to note that pull request senders can  
close pull requests as well.

-- 
With regards,
Christian Walde

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About